Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATION]: pvlib.iotools.read_tmy3 deprecated recolumn parameter removal scheduled for v0.11.0, still there #2324

Open
echedey-ls opened this issue Dec 5, 2024 · 0 comments
Milestone

Comments

@echedey-ls
Copy link
Contributor

Describe the bug
pvlibDeprecationWarning's arise when using parameter recolumn of pvlib.iotools.read_tmy3:

https://github.com/pvlib/pvlib-python/blob/main/pvlib/iotools/tmy.py#L27-L259

While documentation does not state it, the warnings do state that it would have been removed for version v0.11.0.

To Reproduce
Steps to reproduce the behaviour:

  1. View https://github.com/pvlib/pvlib-python/blob/main/pvlib/iotools/tmy.py#L27-L259

Expected behavior
For recolumn to not exist. map_variables to default to True, pretty much like every other function that has the same parameter name.

I propose leaving this for v0.12.0

Versions:

  • pvlib.__version__: latest, v0.11.1

Additional context
Found via #2274

No duplicates found, please correct me if I'm wrong.

@echedey-ls echedey-ls added this to the v0.12.0 milestone Dec 5, 2024
@echedey-ls echedey-ls changed the title pvlib.iotools.read_tmy3 deprecated parameter scheduled for v0.11.0, still there pvlib.iotools.read_tmy3 deprecated recolumn parameter removal scheduled for v0.11.0, still there Dec 5, 2024
@echedey-ls echedey-ls changed the title pvlib.iotools.read_tmy3 deprecated recolumn parameter removal scheduled for v0.11.0, still there [DEPRECATION]: pvlib.iotools.read_tmy3 deprecated recolumn parameter removal scheduled for v0.11.0, still there Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant