-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add sphinx documentation build to CI #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe you want to have a look at Autobuild Documentation for Pull Requests, since you are already using Read the Docs and GitHub. |
Nice, thanks. My reading is that it's currently only available for readthedocs itself. Hoping I'm wrong or that it becomes more widely available soon. I imagine they might be faced with a large increase in compute needs. |
Yeah, it is in beta. You can currently email them to enable the feature. Just wanted to link it here in case you want to try it early or in case it comes out of beta before anybody fixes this issue. They will probably be faced with a large increase in compute needs, yeah, but I hope they can compensate that with paying subscriptions, as this was a largely requested feature for private repositories as well. 😊 |
Thanks, I emailed them. |
RTD added us the the beta program and I modified our RTD webhook to support PR doc builds. Docs for existing PRs will be built after a new commit is pushed. For example: https://external-builds.readthedocs.io/html/pvlib-python/773/index.html Thanks again for pointing out this feature! |
I've been thinking about the gallery contributions and wondering how they can be tested within the CI. I'd like to make sure that these contributions are kept up to date with API changes so newbies don't have to worry about broken examples. I'm just starting to explore this and might open a separate issue to address but I at least wanted to begin to explore the idea here. |
It's not a full test in that it doesn't check for expected output, but sphinx-gallery has some built-in handling for broken tests: https://sphinx-gallery.github.io/stable/configuration.html#dealing-with-failing-gallery-example-scripts |
Thank you for that @kanderso-nrel. An error will be raised which should fit our needs with the CI. |
Sphinx had built in doctests. Enable it like any other extension by adding |
A handful of recent PRs have broken the documentation build. We should add the documentation build to the azure pipelines CI configuration and fail it if the documentation errors.
The text was updated successfully, but these errors were encountered: