Skip to content

add sphinx documentation build to CI #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Aug 23, 2019 · 9 comments · Fixed by #909
Closed

add sphinx documentation build to CI #771

wholmgren opened this issue Aug 23, 2019 · 9 comments · Fixed by #909

Comments

@wholmgren
Copy link
Member

A handful of recent PRs have broken the documentation build. We should add the documentation build to the azure pipelines CI configuration and fail it if the documentation errors.

@Peque
Copy link
Contributor

Peque commented Aug 28, 2019

Maybe you want to have a look at Autobuild Documentation for Pull Requests, since you are already using Read the Docs and GitHub.

@wholmgren
Copy link
Member Author

Nice, thanks. My reading is that it's currently only available for readthedocs itself. Hoping I'm wrong or that it becomes more widely available soon. I imagine they might be faced with a large increase in compute needs.

@Peque
Copy link
Contributor

Peque commented Aug 28, 2019

Yeah, it is in beta. You can currently email them to enable the feature. Just wanted to link it here in case you want to try it early or in case it comes out of beta before anybody fixes this issue.

They will probably be faced with a large increase in compute needs, yeah, but I hope they can compensate that with paying subscriptions, as this was a largely requested feature for private repositories as well. 😊

@wholmgren
Copy link
Member Author

Thanks, I emailed them.

@wholmgren
Copy link
Member Author

RTD added us the the beta program and I modified our RTD webhook to support PR doc builds. Docs for existing PRs will be built after a new commit is pushed. For example: https://external-builds.readthedocs.io/html/pvlib-python/773/index.html

Thanks again for pointing out this feature!

@wholmgren wholmgren modified the milestones: 0.7.0, 0.7.1 Nov 26, 2019
@wholmgren wholmgren modified the milestones: 0.7.1, 0.7.2 Jan 10, 2020
@CameronTStark CameronTStark self-assigned this Feb 17, 2020
@CameronTStark
Copy link
Contributor

I've been thinking about the gallery contributions and wondering how they can be tested within the CI. I'd like to make sure that these contributions are kept up to date with API changes so newbies don't have to worry about broken examples.

I'm just starting to explore this and might open a separate issue to address but I at least wanted to begin to explore the idea here.

@kandersolar
Copy link
Member

kandersolar commented Feb 22, 2020

It's not a full test in that it doesn't check for expected output, but sphinx-gallery has some built-in handling for broken tests: https://sphinx-gallery.github.io/stable/configuration.html#dealing-with-failing-gallery-example-scripts

@CameronTStark
Copy link
Contributor

Thank you for that @kanderso-nrel. An error will be raised which should fit our needs with the CI.

@mikofski
Copy link
Member

Sphinx had built in doctests. Enable it like any other extension by adding sphinx.ext.doctest to the conf.py. SciPy uses this so that all examples are legit. It doesn't run on the CI, but the docs won't build on RTD if any examples fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants