You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ongoing failure of test_get_psm3 is conditioning us (or at least me*) to accept PRs with failing tests. We've been told NREL is going to fix their API, but it keeps not happening, so I really think we should go ahead and mark this test with pytest.xfail. Perhaps pytest.xfail(strict=True) so that the test suite alerts us to when NREL does fix it.
@CameronTStark can you fix this if you agree it makes sense?
So sorry all for any inconveniences or issues as a result of the continued test_get_psm3 failure!
Thanks @CameronTStark and @wholmgren for cleaning up after my PR puppy!
The ongoing failure of
test_get_psm3
is conditioning us (or at least me*) to accept PRs with failing tests. We've been told NREL is going to fix their API, but it keeps not happening, so I really think we should go ahead and mark this test withpytest.xfail
. Perhapspytest.xfail(strict=True)
so that the test suite alerts us to when NREL does fix it.@CameronTStark can you fix this if you agree it makes sense?
test_get_psm3
.The text was updated successfully, but these errors were encountered: