Skip to content

use xfail decorator on test_get_psm3 #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Oct 29, 2019 · 2 comments · Fixed by #803
Closed

use xfail decorator on test_get_psm3 #802

wholmgren opened this issue Oct 29, 2019 · 2 comments · Fixed by #803
Labels

Comments

@wholmgren
Copy link
Member

wholmgren commented Oct 29, 2019

The ongoing failure of test_get_psm3 is conditioning us (or at least me*) to accept PRs with failing tests. We've been told NREL is going to fix their API, but it keeps not happening, so I really think we should go ahead and mark this test with pytest.xfail. Perhaps pytest.xfail(strict=True) so that the test suite alerts us to when NREL does fix it.

@CameronTStark can you fix this if you agree it makes sense?

@CameronTStark
Copy link
Contributor

Will do @wholmgren

@mikofski
Copy link
Member

So sorry all for any inconveniences or issues as a result of the continued test_get_psm3 failure!
Thanks @CameronTStark and @wholmgren for cleaning up after my PR puppy!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants