Skip to content

move kimber and HSU to soiling.py and remove losses.py #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikofski opened this issue Mar 17, 2020 · 4 comments · Fixed by #937
Closed

move kimber and HSU to soiling.py and remove losses.py #935

mikofski opened this issue Mar 17, 2020 · 4 comments · Fixed by #937
Labels
Milestone

Comments

@mikofski
Copy link
Member

mikofski commented Mar 17, 2020

Is your feature request related to a problem? Please describe.
see #891- the question is where to put different losses like snow, soiling, but not all effects are considered losses by all, so where would transformers go? or curtailment? it's a slipper slope, where would inverter efficiency go? Everything in the loss tree would get jumbled together

Describe the solution you'd like
rename losses.py to soiling.py

Describe alternatives you've considered
put all losses of different types into losses.py except then some things that might not be considered losses will be confusing?

Additional context
see #891, #577, #764

@cwhanse
Copy link
Member

cwhanse commented Mar 17, 2020

@mikofski by opening this issue, should we assume you are +1 to this question?

@mikofski
Copy link
Member Author

mikofski commented Mar 17, 2020

Sorry I linked to the wrong issue/PR. I meant 891 not 931 or 764 :(

Yes, I think it's a good idea, I believe that losses.py is likely to get quite large, and like someone else said, maybe it was Steve Ransom, there maybe many items in the loss tree that are not necessarily considered losses by everyone.

However, it might make sense later to think of a subpackage to group/organize loss-tree items into. In SolarFarmer, they are collectively called effects instead of losses. So losses are just negative effects, whereas a boost/gain is a positive effect. But, I don't think we have to make that decision at this time, b/c the pvlib package is perhaps not that crowded yet. I don't know how to decide when it becomes too crowded, probably when people start complaining or there's some other issue.

@mikofski
Copy link
Member Author

closed in favor of #891 sorry for the clutter - I got confused :(

@cwhanse
Copy link
Member

cwhanse commented Mar 18, 2020

actually I thought you were getting ahead - let's use this issue to move losses.py to soiling.py.

@cwhanse cwhanse reopened this Mar 18, 2020
@wholmgren wholmgren added the api label Mar 21, 2020
@wholmgren wholmgren added this to the 0.7.2 milestone Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants