-
Notifications
You must be signed in to change notification settings - Fork 1.1k
move kimber and HSU to soiling.py and remove losses.py #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sorry I linked to the wrong issue/PR. I meant 891 not 931 or 764 :( Yes, I think it's a good idea, I believe that However, it might make sense later to think of a subpackage to group/organize loss-tree items into. In SolarFarmer, they are collectively called effects instead of losses. So losses are just negative effects, whereas a boost/gain is a positive effect. But, I don't think we have to make that decision at this time, b/c the |
closed in favor of #891 sorry for the clutter - I got confused :( |
actually I thought you were getting ahead - let's use this issue to move |
Is your feature request related to a problem? Please describe.
see #891- the question is where to put different losses like snow, soiling, but not all effects are considered losses by all, so where would transformers go? or curtailment? it's a slipper slope, where would inverter efficiency go? Everything in the loss tree would get jumbled together
Describe the solution you'd like
rename
losses.py
tosoiling.py
Describe alternatives you've considered
put all losses of different types into
losses.py
except then some things that might not be considered losses will be confusing?Additional context
see #891, #577, #764
The text was updated successfully, but these errors were encountered: