Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findBestAppIcon should choose the last among equally suitable icons, not the first #4486

Closed
cairomassimo opened this issue Oct 29, 2023 · 1 comment
Assignees
Labels

Comments

@cairomassimo
Copy link

Per https://w3c.github.io/manifest/#icons-member:

If there are multiple equally appropriate images in icons, a user agent MUST use the last one declared in order at the time that the user agent collected the list of icons.

PWABuilder should mimic user agents and follow this rule, but does not.

See:

const exactMatch = iconInfos.find(i => i.isExactMatch(purpose, desiredWidth, desiredHeight, mimeType));

@cairomassimo
Copy link
Author

Thank you! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done ✔️
Development

No branches or pull requests

5 participants