Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JS (remove jQuery) #130

Open
pwkip opened this issue Jan 15, 2025 · 1 comment
Open

Improve JS (remove jQuery) #130

pwkip opened this issue Jan 15, 2025 · 1 comment

Comments

@pwkip
Copy link
Owner

pwkip commented Jan 15, 2025

Long term plan: remove all jQuery code.

Short term: improve compatibility with other jQuery versions: https://wordpress.org/support/topic/error-with-2-5-6/#post-18237766

@saidul
Copy link

saidul commented Jan 15, 2025

const buttonEntries = [ ... jQuery('button', form.$form) ].map(entry => [entry.name, entry.value]);

jQuery does not return iterable data. temporary solution could be using Array.from:

const buttonEntries = [ ... Array.from(jQuery('button', form.$form)) ].map(entry => [entry.name, entry.value]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants