You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Performing search highlights initially ALL first occurences on different pages with highlight-active-color.
This persist even after pressing n/N for the next/previous search result. It only gets partially fixed after the actual current entry gets on the next page (since on previous page all search results will be left highlighted with highlight-color).
In my opinion, at all times only the real current search result should be highlighted with the active color.
The text was updated successfully, but these errors were encountered:
I would propose the following behavior for searching:
only highlight one "real" current search result
as long as it stays in the visible range, search next/previous will go to the next/previous result relative to it, regardless if we scrolled to some other page in a meantime
only after the current search result goes out of the visible range, we reset it, and the next invocation of search next/previous starts from the top/bottom of the current page
I would not "jump" start the search at a new location unless an explicit action to relocate is made. Scrolling the view should not do that even if the current match goes out of view. An explicit click inside a page of page jump key might do that, but the action would have to have the expectation of moving the focus. In almost every editor/browser/etc. I can think of works this way, and not only is it habitual to expect the focus jumps back to the match instead of the other way around but also useful.
Sure, that would certainly work too (and perhaps is actually better). I just tried to come up with something more similar to the way zathura works now, but maybe such considerations shouldn't be entertained.
Performing search highlights initially ALL first occurences on different pages with
highlight-active-color
.This persist even after pressing
n
/N
for the next/previous search result. It only gets partially fixed after the actual current entry gets on the next page (since on previous page all search results will be left highlighted withhighlight-color
).In my opinion, at all times only the real current search result should be highlighted with the active color.
The text was updated successfully, but these errors were encountered: