Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated url.parse() is used - results in malformed request #35

Open
amakhrov opened this issue Aug 9, 2019 · 0 comments
Open

Deprecated url.parse() is used - results in malformed request #35

amakhrov opened this issue Aug 9, 2019 · 0 comments

Comments

@amakhrov
Copy link

amakhrov commented Aug 9, 2019

url.parse is a part of now deprecated Legacy API
https://nodejs.org/api/url.html#url_legacy_url_api

Url parsing differs from a recommended WHATWG: https://nodejs.org/api/url.html#url_percent_encoding_in_urls

In certain cases it results in malformed http requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amakhrov