Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few minor issues #160

Open
vertexodessa opened this issue Oct 4, 2016 · 1 comment
Open

Few minor issues #160

vertexodessa opened this issue Oct 4, 2016 · 1 comment
Assignees

Comments

@vertexodessa
Copy link
Contributor

vertexodessa commented Oct 4, 2016

Revision 1bc7069 (to make sure all the lines are correct)

Incorrect variable assignment:

  ret = inet_pton(ss.ss_family, host, addr);
  if (ret != 1)
  {
    int err = errno;
    rtLogError("failed to parse: %s as valid ipv4 address", host);
    error = rtErrorFromErrno(err);
  }
  error = RT_OK;

"error" is used incorrectly. it will always be equal to RT_OK.
rtRemoteSocketUtils.cpp: 196, 198


Incorrect/strict float comparison:
pxScene2d.cpp: lines 506, 513, 532, 543, 932, 975, 984
pxContextGL.cpp: lines 1072, 1074, 1625, 1642
pxFont.cpp: 310
pxText.cpp: 123, 157
pxTextBox.cpp: 272, 463, 479, 743, 770, 840, 856, 872, 875, 896, 902, 1027
pxImage.cpp: 136, 146
pxImage9.cpp: 88, 89
pxInterpolators.cpp: 18, 21, 64, 169
rtValue.cpp: 53, 54, 280, 281


pxMatrix4T class implements copy ctor but not "operator ="

@conniefry
Copy link
Contributor

Not sure if all of these issues still persist, but would be good to review and clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants