Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aiofiles instead of aiofile #281

Closed
ashwinvin opened this issue Feb 28, 2021 · 3 comments
Closed

Use aiofiles instead of aiofile #281

ashwinvin opened this issue Feb 28, 2021 · 3 comments
Assignees
@pratishrai
Labels
Enhancement New feature, request, or thing Good First Issue Good for newcomers

Comments

@ashwinvin
Copy link
Member

ashwinvin commented Feb 28, 2021 •
edited
Loading

Feature

  • Change all the usage of aiofile to aiofiles

Reason

  • It features a more pythonic api.
@ashwinvin ashwinvin added Enhancement New feature, request, or thing Good First Issue Good for newcomers labels Feb 28, 2021
@Iapetus-11
Copy link
Member

Possible performance enhancement.

go on...

@pratishrai
Copy link

I wanna work on this issue.

@Iapetus-11
Copy link
Member

mosquito/aiofile#18 According to this post, aiofile appears to be faster than aiofiles, so we shouldn't switch for the time being. If something else arises further down the line, we can switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratishrai pratishrai

Labels
Enhancement New feature, request, or thing Good First Issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashwinvin @Iapetus-11 @pratishrai