Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent evaluation perspective across the code base #18

Open
knutole opened this issue Apr 8, 2023 · 1 comment
Open

Ensure consistent evaluation perspective across the code base #18

knutole opened this issue Apr 8, 2023 · 1 comment

Comments

@knutole
Copy link

knutole commented Apr 8, 2023

There are three ways to return evaluations:

  • From the perspective of whose turn it is (ie. +5 is advantage to the side whose turn it is)
  • From the perspective of White always (ie. +5 is advantage White, no matter whose turn it is)
  • From the perspective of Black always (ie. +5 is advantage Black, no matter whose turn it is)

Currently there is a happy mix in the codebase:

Suggested solution:

  • Use turn_perspective global option for all functions, default to True (ie. Turn perspective).
  • Problem: backwards compatibility for above functions that use White perspective.
@kieferro
Copy link
Member

kieferro commented Apr 8, 2023

Good point. We should definitely try to standardize that. If there's no other way, we could also consider deviating a bit from backwards compatibility and doing a major version bump with bigger changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants