Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad output shape for ortho_forest effect #188

Closed
vasilismsr opened this issue Nov 23, 2019 · 0 comments
Closed

Bad output shape for ortho_forest effect #188

vasilismsr opened this issue Nov 23, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@vasilismsr
Copy link
Contributor

Take the example from Section 1.1 and 1.2 from the ortho forest notebook:
https://github.com/microsoft/EconML/blob/master/notebooks/Orthogonal%20Random%20Forest%20Examples.ipynb

When T is a vector of (n,), then the effect(X) of the ContinuousOrthoForest returns a (n, 1) vector.

When T is (n, 2) (e.g. if we just duplicate T in cell 6) then effect(X) correctly a (n,) vector.

When T is (n, 1) (e.g. if we reshape T in cell 6) it runs super slow and had to be cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants