Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ID algorithm? #50

Closed
djinnome opened this issue Apr 4, 2019 · 7 comments
Closed

Implementation of ID algorithm? #50

djinnome opened this issue Apr 4, 2019 · 7 comments

Comments

@djinnome
Copy link

djinnome commented Apr 4, 2019

Hi there,

Back door and IV is nice, but for larger graphs, I am wondering if it would be worthwhile implementing Ilya Shpitsers ID algorithm, which is complete. Implementations of ID are currently available in R and in clojure.

By the way, if you haven't checked out Whittemore, it implements a causal programming paradigm similar in philosophy to doWhy

@amit-sharma
Copy link
Member

Thanks @djinnome ! Definitely, implementing the ID algorithm is on our priority list, but being delayed with work on refutations. Would you be willing to contribute to the development?

Yes, I really the idea behind Whittemore--had a chance to talk to Joshua (who built Whittemore) a few weeks back.

@djinnome
Copy link
Author

djinnome commented Apr 12, 2019 via email

@amit-sharma
Copy link
Member

Sounds great. Let me know once you are ready. Happy to chat in case you need you need more details on the library's code structure.

@gianlucadetommaso
Copy link

Hi all, was there meanwhile any progress on this front?

@amit-sharma
Copy link
Member

yes, the ID algorithm is now implemented for identification.
https://microsoft.github.io/dowhy/example_notebooks/identifying_effects_using_id_algorithm.html

However, estimation based on the probability expressions returned by ID algorithm is not yet supported.

@gianlucadetommaso
Copy link

gianlucadetommaso commented Apr 1, 2022

Thank you. Any chance somebody also implemented the Adjustment Criterion by Shpitser (here, Definition 5)? This is a complete criterion for identification via covariate adjustment.

@amit-sharma
Copy link
Member

That's not implemented, but it will a simple exercise to implement it by extending the backdoor criterion. Would you like to implement it @gianlucadetommaso ? I've added an issue #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants