Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom (pre-)commands for UnitTest and Coverage #45

Open
Paebbels opened this issue Mar 10, 2022 · 2 comments
Open

Support custom (pre-)commands for UnitTest and Coverage #45

Paebbels opened this issue Mar 10, 2022 · 2 comments
Labels
Enhancement New feature or request Pipeline Reusable workflows

Comments

@Paebbels
Copy link
Member

Paebbels commented Mar 10, 2022

In some cases, the test environment needs to be prepared by custom commands.

Allow a user to specify custom commands, that run before main steps in UnitTest or Coverage.


Usecases:

  • Setup dummy binaries like ghdl, so pyEDAA.CLITool can find a valid path.
    • create empty files (e.g. via touch)
    • copy dummy scripts to expected location (e.g. Python script emulating the ghdl CLI)
    • full ghdl installation
@umarcor
Copy link
Member

umarcor commented Mar 14, 2022

Since UnitTesting and Coverage workflows have a single job each, it would be feasible to convert the steps into a composite action. Then, users who want to execute pre- or post- steps would write the matrix in their pipeline and call the composite action, instead of consuming the reusable workflow. That would solve #44 as well.

@umarcor
Copy link
Member

umarcor commented Mar 14, 2022

Is there a demo of which steps would need to be added? I.e., some repo which uses a custom UnitTesting or Coverage workflow, instead of reusing the one from here as-is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Pipeline Reusable workflows
Projects
None yet
Development

No branches or pull requests

2 participants