-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate number of electrodes in parallel to make a cell #4833
Comments
Happy to remove this in favor of just scaling the electrode area properly. How about the number of cells in series? It only really applies to lead-acid batteries (to get to 12V when the OCV is ~2V) |
Should we just switch to "Electrode area [m2]" instead? |
It's not obvious to new PyBaMM users how to account for multiple layers in a cell. For example, Chen et al. and the papers based on it (O'Kane et al., O'Regan et al.) handle the double-coated electrode by doubling the electrode width, but other papers use different conventions. |
I think that here the best development would be disentangling the parameterisation of the electrical model (relation of cell current to 1D macroscopic current density) from any parameterisation of the actual physical layout of the cell, for thermal modelling or other purposes. Even if you can count your electrodes and their coatings, you need to make some assumption about what the 'out-of-plane' area of the SPM/SPMe/DFN should be, because negative electrode, positive electrode and separator all have different areas and while basically only the facing area counts, there can be edge effects.. So I'd recommend a simple |
I think removing the "number of electrodes in parallel" will help with this, as we can make it clear that the electrode width/area corresponds to a single anode/separator/cathode layer
Sounds like a good idea. The challenge is what if the user has a 3D pouch cell model requiring inputting height and width - in that case should they also specify the electrode area (and be responsible for making sure it's compatible with the height and width), or would PyBaMM calculate it for them based on height and width they provide? And how does this interact with the thermal model? Perhaps a solution is just that different form factors require different parameters. |
@valentinsulzer My opinion would be to make the user responsible in all cases, because the role of the parameter value in PyBaMM is to define the coefficients for the model equations, not to oblige a specific physical interpretation. For example, even when specifying "height and width", what do we mean? The electrode sheet dimensions (current collector)? The coated dimensions? They're not co-terminous. We have opened pouch cells with slightly chamfered corners on the electrodes so the coated area isn't even a rectangle if you're being pedantic. In any case you have some set of actually measurable dimensions, which are difficult to generalise from form factor to form factor (or even cell design to cell design), and then there's some set of needed coefficients in the model equations. For the thermal model these needed coefficients are different and more numerous, and trace back to more materials besides active materials, but the connection to geometry remains a little distant because what we ultimately need are total thermal masses and effective conductivities. |
Yes, I think that makes sense. So it sounds like what we need is this:
|
Hi all, Thanks for the detailed discussion on this! I agree that deprecating the "Number of electrodes in parallel" parameter in favor of using "Electrode area [m²]" sounds like a good way forward. It simplifies the model and removes potential confusion, especially for newer PyBaMM users. I also think that handling multiple layers by scaling the electrode width/area, as you mentioned, is a practical approach. For higher-dimensional models, like 3D pouch cells, I agree that providing both height and width makes sense for user flexibility. Just to clarify the next steps and best implementation:
As I'm still new to PyBaMM, any guidance from all of you would be very helpful for me in implementing these changes effectively. Looking forward to hearing your thoughts on this, and happy to help implement these changes. |
The "Number of electrodes connected in parallel to make a cell" parameter is confusing and not always used properly. For example, it is not used to calculate the area of the current collector:
PyBaMM/src/pybamm/parameters/geometric_parameters.py
Line 44 in 7419219
PyBaMM/src/pybamm/parameters/lithium_ion_parameters.py
Line 116 in 7419219
We could go through and try and find and fix all of these, or we could just deprecate this parameter. I think we should do the latter.
The text was updated successfully, but these errors were encountered: