Skip to content

Commit 0a2efdf

Browse files
authored
[smart_holder] Configure only one job per OS kind to build and run tests with -DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT (#5307)
* Configure only one job per OS kind to build and run tests with `-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT` Remove ci_sh_def.yml Piggy-backed: Add `smart_holder` to `branches` in emscripten.yaml * Fix misunderstanding. * Add `/GR /EHsc` for Windows. * #error "Intentional Breakage" (to verify: PYBIND11_ACTUALLY_USING_SMART_HOLDER_AS_DEFAULT) * Revert "#error "Intentional Breakage" (to verify: PYBIND11_ACTUALLY_USING_SMART_HOLDER_AS_DEFAULT)" This reverts commit 4f6f5cb.
1 parent 2885b8d commit 0a2efdf

File tree

4 files changed

+13
-1486
lines changed

4 files changed

+13
-1486
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,18 @@ jobs:
6868
# Extra ubuntu latest job
6969
- runs-on: ubuntu-latest
7070
python: '3.11'
71-
71+
- runs-on: ubuntu-latest
72+
python: '3.12'
73+
args: >
74+
-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT"
75+
- runs-on: macos-13
76+
python: '3.12'
77+
args: >
78+
-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT"
79+
- runs-on: windows-2022
80+
python: '3.12'
81+
args: >
82+
-DCMAKE_CXX_FLAGS="/DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT /GR /EHsc"
7283
7384
name: "🐍 ${{ matrix.python }} • ${{ matrix.runs-on }} • x64 ${{ matrix.args }}"
7485
runs-on: ${{ matrix.runs-on }}

0 commit comments

Comments
 (0)