-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow action to show on "warning" #354
Comments
For easier backwards compatibility I would say |
Yeah, agreed with Toke, and otherwise this looks good. On warning means on warning, not error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
The Action defines a couple of specific
on
states of when it can be triggered, likefailed
andprocessed
. However it lacks the ability to be shown only when (at least) warnings have occurred.This would be relevant visually for Pyblish-QML and Pyblish-Lite so for now I added this to pyblish-base as it also relates to the pyblish documentation itself.
Discussion
The question of course would be whether
on = "warning"
would also be valid whenever no warning was logged but an error did occur. As if the 'warning' level is the minimum level of verbosity for it to be shown, or whether it should be an exact match. In the case of only an exact match it should then still be skipped and only show whenever at least one warning was logged. That's up for discussion here.Note that there's currently no state that combines to different states, e.g.
warning+failed
. The problem at hand might also be solved differently, e.g. having a state likeon="custom"
that defines a method on the action like:The text was updated successfully, but these errors were encountered: