Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adam optimiser failing tests #164

Closed
1 of 2 tasks
BradyPlanden opened this issue Jan 9, 2024 · 0 comments · Fixed by #166
Closed
1 of 2 tasks

Adam optimiser failing tests #164

BradyPlanden opened this issue Jan 9, 2024 · 0 comments · Fixed by #166
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented Jan 9, 2024 •
edited
Loading

Python Version

N/A

Describe the bug

Convergence issues for the Adam optimiser. Potential areas to investigate:

  • The solvers response to np.inf
  • Additional iterations required?

Steps to reproduce the behaviour

nox -s unit

Relevant log output

https://github.com/pybop-team/PyBOP/actions/runs/7464440347/job/20311432705
@BradyPlanden BradyPlanden added the bug Something isn't working label Jan 9, 2024
@BradyPlanden BradyPlanden mentioned this issue Jan 10, 2024
Merged
@BradyPlanden BradyPlanden linked a pull request Jan 10, 2024 that will close this issue
Revert np.inf return for non-physical optimisation locations #166
Merged
@BradyPlanden BradyPlanden moved this to In Progress in v24.3 Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.3 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
v24.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert np.inf return for non-physical optimisation locations pybop-team/PyBOP
1 participant
@BradyPlanden