Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct model without pybamm build and add kwargs #231

Closed
BradyPlanden opened this issue Mar 10, 2024 · 0 comments · Fixed by #256
Closed

Construct model without pybamm build and add kwargs #231

BradyPlanden opened this issue Mar 10, 2024 · 0 comments · Fixed by #256
Assignees
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

At the moment, on construction the pybamm.lithium_ion.SPM and SPMe are built. To avoid this, the following arg is available:

pybamm.lithium_ion.SPM(build=False) 

Additionally, we are not passing kwargs to the pybamm model, this should be updated at the same time.

Motivation

PyBOP aims to build the model when required (inclusive of rebuild) and as such the initial build should be redundant.

Possible implementation

No response

Additional context

No response

@BradyPlanden BradyPlanden added the enhancement New feature or request label Mar 10, 2024
@BradyPlanden BradyPlanden moved this to In Progress in v24.6 May 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.6 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants