Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Update benchmarks post #255 #333

Closed
BradyPlanden opened this issue May 23, 2024 · 0 comments · Fixed by #337
Closed

[Bug]: Update benchmarks post #255 #333

BradyPlanden opened this issue May 23, 2024 · 0 comments · Fixed by #337
Assignees
@BradyPlanden
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

N/A

Describe the bug

Benchmarks need to be updated after the API change from #255: https://github.com/pybop-team/PyBOP/actions/runs/9207704386

Steps to reproduce the behaviour

See above. Alternatively, run the benchmarks locally as per: https://github.com/pybop-team/PyBOP/blob/develop/benchmarks/README.md

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label May 23, 2024
@BradyPlanden BradyPlanden self-assigned this May 30, 2024
@BradyPlanden BradyPlanden mentioned this issue May 31, 2024
Merged
15 tasks
@BradyPlanden BradyPlanden linked a pull request May 31, 2024 that will close this issue
Restores Benchmarks #337
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradyPlanden BradyPlanden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restores Benchmarks pybop-team/PyBOP
1 participant
@BradyPlanden