You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the tests fails for the MSMR model due to a bug in PyBaMM version 23.9, specifically:
pybamm/models/full_battery_models/lithium_ion/msmr.py:23: OptionError.
elif "particle" in options and options["particle"] == "MSMR":
> raise pybamm.OptionError(
"'particle' must be 'MSMR' for MSMR not '{}'".format(
options["particle"]
)
E pybamm.expression_tree.exceptions.OptionError: 'particle' must be 'MSMR' for MSMR not 'MSMR'
In PyBaMM v24.1, the line is updated (note the not equal) to:
elif "particle" in options and options["particle"] != "MSMR":
Steps to reproduce the behaviour
Run tests/unit/test_models.py::TestModels::test_model_classes with PyBaMM v23.9.
Python Version
3.10
Describe the bug
One of the tests fails for the MSMR model due to a bug in PyBaMM version 23.9, specifically:
pybamm/models/full_battery_models/lithium_ion/msmr.py:23: OptionError.
In PyBaMM v24.1, the line is updated (note the
not equal
) to:Steps to reproduce the behaviour
Run tests/unit/test_models.py::TestModels::test_model_classes with PyBaMM v23.9.
Relevant log output
The text was updated successfully, but these errors were encountered: