Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: One of the MSMR tests fails in the scheduled tests #347

Closed
NicolaCourtier opened this issue Jun 6, 2024 · 0 comments · Fixed by #348
Closed

[Bug]: One of the MSMR tests fails in the scheduled tests #347

NicolaCourtier opened this issue Jun 6, 2024 · 0 comments · Fixed by #348
Assignees
Labels
bug Something isn't working

Comments

@NicolaCourtier
Copy link
Member

Python Version

3.10

Describe the bug

One of the tests fails for the MSMR model due to a bug in PyBaMM version 23.9, specifically:
pybamm/models/full_battery_models/lithium_ion/msmr.py:23: OptionError.

elif "particle" in options and options["particle"] == "MSMR":
>           raise pybamm.OptionError(
                "'particle' must be 'MSMR' for MSMR not '{}'".format(
                    options["particle"]
                )
E               pybamm.expression_tree.exceptions.OptionError: 'particle' must be 'MSMR' for MSMR not 'MSMR'

In PyBaMM v24.1, the line is updated (note the not equal) to:

elif "particle" in options and options["particle"] != "MSMR":

Steps to reproduce the behaviour

Run tests/unit/test_models.py::TestModels::test_model_classes with PyBaMM v23.9.

Relevant log output

https://github.com/pybop-team/PyBOP/actions/runs/9398312114/job/25883408789
@NicolaCourtier NicolaCourtier added the bug Something isn't working label Jun 6, 2024
@NicolaCourtier NicolaCourtier self-assigned this Jun 6, 2024
@NicolaCourtier NicolaCourtier linked a pull request Jun 6, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant