Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: self._boundaries not created for pybop.PSO #380

Closed
BradyPlanden opened this issue Jun 28, 2024 · 0 comments · Fixed by #381
Closed

[Bug]: self._boundaries not created for pybop.PSO #380

BradyPlanden opened this issue Jun 28, 2024 · 0 comments · Fixed by #381
Assignees
@BradyPlanden
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.12

Describe the bug

For pybop.PSO, the self._boundaries attribute is not currently created:

PyBOP/pybop/optimisers/base_pints_optimiser.py

Line 143 in 9ac4d01

elif issubclass(self.pints_optimiser, PintsPSO):

As such, the optimiser exceeds acceptable values during optimisation.

Steps to reproduce the behaviour

Run the spm_pso.py example script and view the optimiser parameter vector.

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label Jun 28, 2024
@BradyPlanden BradyPlanden self-assigned this Jun 28, 2024
@BradyPlanden BradyPlanden mentioned this issue Jun 28, 2024
Merged
15 tasks
@BradyPlanden BradyPlanden linked a pull request Jun 28, 2024 that will close this issue
Restore boundaries to pybop.PSO #381
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradyPlanden BradyPlanden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore boundaries to pybop.PSO pybop-team/PyBOP
1 participant
@BradyPlanden