Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom item_type at the public API layer to enable easier library extensibility #1934

Open
interifter opened this issue Dec 21, 2024 · 2 comments

Comments

@interifter
Copy link

interifter commented Dec 21, 2024

Problem trying to solve

While this library is fantastic, there are some capabilities I would like to include via extending the classes. Specifically, I want to be able to get an issue's fields by display name, hiding the several queries I must make to the REST API to get a custom field's display name.

In order to properly extend Field, however, I have to either reimplement significant parts of the methods, or make the standard call, and re-instantiate all the returned issues.

For example:

    def search_issues(
        self,
        jql_str: str,
        startAt: int = 0,
        maxResults: int = 50,
        validate_query: bool = True,
        fields: str | list[str] | None = "*all",
        expand: str | None = None,
        properties: str | None = None,
        json_result: bool = False,
        use_post: bool = False,
    ) -> dict[str, Any] | ResultList[Issue]:
        result = super().search_issues(jql_str, startAt, maxResults, validate_query, fields, expand, properties, json_result, use_post)
        if json_result:
            return result
        items = [ExtendedIssues(x) for x in result]
        return ResultList(items, result.startAt, result.maxResults, result.total, result.isLast)

Possible solution(s)

A couple of thoughts come to mind:

  1. Allow us to specify custom types at client instantiation (probably the safest/easiest)
  2. Allow each public method that will return an issue type to have item_type exposed (probably bug-prone and messier)
  3. Expose a GenericJiraClient that allows someone to implement a concrete client with the types passed into the class definition (may be most elegant, but could look funny with multiple concrete types passed in)

1. Example Exposing CustomTypes at Instantiation

This seems a bit friendlier

class CustomIssue(Issue):

    def get_field(self, field_name: str, by_display_name: bool = False) -> Any:
        if not hasattr(self.fields, field_name) and by_display_name:
            return ...
        return super().get_field(field_name)

client = JIRA("server", auth=(), item_types={"issue": CustomIssue}) # Will only replace 'issue' type. All other defaults remain the same
issues = client.search_issues("project=ABC and status=closed")
field = issues[0].get_field("Epic Status", by_display_name=True)

2. Example Exposing item_type for search_issues

This one feels like it would be the most error-prone, since I think you would have to expose something similar for 9 total methods related to fields.

class CustomIssue(Issue):

    def get_field(self, field_name: str, by_display_name: bool = False) -> Any:
        if not hasattr(self.fields, field_name) and by_display_name:
            return ...
        return super().get_field(field_name)

client = JIRA(...)
issues = client.search_issues("project=ABC and status=closed", item_type=CustomIssue)
field = issues[0].get_field("Epic Status", by_display_name=True)

3. Example with a GeneticJiraClient

The biggest problem with this is there appears to be 41 different classes inheriting from Resource

Could very easily be the most arduous of the three.

from typing import TypeVar
from jira.resources import Issue, User
T = TypeVar("T", Issue)
U = TypeVar("U", User)
# et cetera

class GenericJiraClient(Generic[T, U, ...]): ...

class JIRA(GenericJiraClient[Issue, User, ....]): ...

# Or, custom:

class MyJiraClient(GenericJiraClient[CustomIssue]): ...

Alternatives

A quicker solution would probably be to just expose methods like these via the JIRA class, and other classes, directly. But I am thinking about extensibility in the field, for users/teams who don't want to wait for a PR to get merged and a new release to happen.

Additional Context

I took a look through the source code, and no other approaches came to mind.

@interifter
Copy link
Author

After thinking on it for a couple days, I think passing custom types as a dict into JIRA would be the easiest to refactor, and minimize required changes.

@dimitarOnGithub
Copy link

FWIW, in my projects, I have a dictionary declaring all known (or needed) fields and their what I'd like their equivalent to be, for example:

fields_map = {
    'Custom Field 1': 'customfield_10000',
    'Custom Field 2': 'customfield_10001'
}

and then I have a layer on top of the library where I initialize my own objects:

class MyCustomIssue:

     self.my_var = self.retrieve_field_value('Custom Field 1')
     self.my_other_var = self.retrieve_field_value('Custom Field 2')

    def retrieve_field_value(self, issue: jira.resources.Issue, field_name: str):
        field = getattr(issue, fields_map.get('field_name'))  # Get the attribute from the issue object
        return field.value  # Oversimplified return of said attribute's value

In other cases, I've also end up declaring the various fields with a bit more detail as the JIRA API itself returns the fields in different manner - when retrieved via a search, you'd get the field id (customfield_10000), however if you're retrieving the History tab for example, it will be returned via a label (Custom Field 1), so I personally accounted for that by declaring both of these internally and then working with them depending on what action I'm performing

class JiraField:

    self.field_id = 'customfield_10000'  # How is the field returned from the library/API
    self.label = 'Custom Field 1'  # How is the field displayed in JIRA
    self.var_name = 'my_var'  # This is my local classes variable

Just putting here as food for thought,

After thinking on it for a couple days, I think passing custom types as a dict into JIRA would be the easiest to refactor, and minimize required changes.

but I do agree that a simple dictionary should be easiest to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants