Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGO benchmark results for the library #123

Open
zamazan4ik opened this issue Jul 28, 2024 · 1 comment
Open

PGO benchmark results for the library #123

zamazan4ik opened this issue Jul 28, 2024 · 1 comment

Comments

@zamazan4ik
Copy link

Hi! Thank you for the library!

As far as I see, PGO is already integrated into the build scripts. However, after a quick search in the repository I didn't find PGO benchmarks for the library.

Did anyone test performance improvements for the library by enabling PGO? It would be awesome if you could share these numbers with the auditory in some way (at least here, in Issues) - it can convince more people to enable PGO for their builds. Also, I would be happy to add the results to my https://github.com/zamazan4ik/awesome-pgo repository.

Thank you.

@davidhewitt
Copy link
Collaborator

We did this mostly following the process we'd already undergone in pydantic-core.

IIRC the PGO did show improvements, we can test the shipped artefacts against locally-built to see the difference. I think @samuelcolvin did this.

Btw see also PyO3/maturin#1840 - I would love for some help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants