Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower MSRV to 1.75 #1315

Closed
tiran opened this issue Jun 5, 2024 · 0 comments · Fixed by #1316
Closed

Lower MSRV to 1.75 #1315

tiran opened this issue Jun 5, 2024 · 0 comments · Fixed by #1316
Assignees

Comments

@tiran
Copy link
Contributor

tiran commented Jun 5, 2024

pydantic-core 2.18.4 sets minimum supported Rust version to 1.76 in its Cargo.toml. That is higher than actually necessary. pydantic-core compiles and tests just fine with Rust 1.75. I would like to lower MSRV to 1.75.

Motivation: The latest versions of RHEL 8 (8.10) and RHEL 9 (9.4) as well as UBI 8 and UBI 9 container images have Rust 1.75. I would like to build pydantic-core from sources without patching.

PS: Rust 1.74 and earlier versions are not supported. rust-lang/rust#91611 feature stabilized in Rust 1.75.

      error[E0562]: `impl Trait` only allowed in function and inherent method return types, not in trait method return types
         --> src/input/input_abstract.rs:208:23
          |
      208 |     fn iter(&self) -> impl Iterator<Item = Self::Item<'_>>;
          |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          |
          = note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants