Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining state.allow_partial = false; #1523

Open
6 tasks
samuelcolvin opened this issue Nov 3, 2024 · 0 comments
Open
6 tasks

remove remaining state.allow_partial = false; #1523

samuelcolvin opened this issue Nov 3, 2024 · 0 comments

Comments

@samuelcolvin
Copy link
Member

As per #1512, the following validators disable partial support:

  • DataclassArgsValidator
  • ModelFieldsValidator
  • TupleValidator
  • ArgumentsValidator
  • GeneratorValidator
  • DefinitionRefValidator - maybe this is as simple as removing the line, but I don't want to think about it right now

We should remove state.allow_partial = false; and instead set it on all but the last last element/value during validation, as we do for other collections already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant