-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAC address type #15
Comments
looking at https://github.com/mentalisttraceur/python-macaddress/blob/main/macaddress.py I think it would be easier to implement this directly ourselves. |
I’m thinking:
I know Cisco tend to return MAC and IPv6 with weird formats, such as |
I suggest only supporting |
Sounds good, from what little I know of Mac addresses. We can do some of the checking in rust. |
EUI-64 should probably be possible too, as I see PSQL supports both. I'm not sure whether they should be the same, or have two different classes?
I'll start with a pure Python implementation (unless someone beats me to it), and then I'll iterate on it with rust to see if it's faster (and worth the cost of maintenance). The decision can then be made at a later point. As a side question, since the JSON schema org is no longer adding types ( json-schema-org/json-schema-vocabularies#49 (comment) ), is. @dmontagu (author of pydantic/pydantic#5029 (review) ) aware of this package? There might be a need for JSON schema extensions 😊 |
These types should support JSON Schema via No need for pydantic to know about them specifically. |
See #8
The text was updated successfully, but these errors were encountered: