Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International market data - functionality addition request #408

Closed
CNuge opened this issue Oct 10, 2017 · 1 comment
Closed

International market data - functionality addition request #408

CNuge opened this issue Oct 10, 2017 · 1 comment

Comments

@CNuge
Copy link

CNuge commented Oct 10, 2017

Hello,

I have developed a program to use google finance to scrape stock data for non-us markets (i.e. TSE, TYO, SSE). This functionality is currently not supported by pandas-datareader as far as I can tell and I am hoping to add a 'pandas_datareader.data.international_quotes()' function to this repository.

I would like to know if:

  1. You are accepting additions of this kind
  2. What sort of dependency limitations there are (i.e. my current build uses BeautifulSoup to read the html and I want to know if I should change this).

My current international stock scraping function can be found here:

https://github.com/CNuge/general_use_functions/blob/master/international_stock_scraper.py

Thanks for the feedback,
-Cam

@rsvp
Copy link

rsvp commented Oct 10, 2017

@CNuge hi, as you probably know, Google Finance is currently
in its reconstruction period.

Your proposed scrape code is not a robust solution (relative to API code)
since page layouts are subject to whimsical UI changes.
That said, it may provide a good fallback if Google trashes its API
since they have no intention of deprecating their Finance web pages.

@CNuge CNuge closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants