Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ABlog CSS now that it has better-labeled HTML #1067

Closed
choldgraf opened this issue Nov 19, 2022 · 4 comments · Fixed by #1075 or #1118
Closed

Update ABlog CSS now that it has better-labeled HTML #1067

choldgraf opened this issue Nov 19, 2022 · 4 comments · Fixed by #1075 or #1118
Labels
kind: enhancement New feature or request tag: CSS CSS and SCSS related issues
Milestone

Comments

@choldgraf
Copy link
Collaborator

I noticed that ABlog made a release that added the extra HTML structure to make it much easier to style.

For example: their landing page now has sidebar items that look like:

<div class="ablog-sidebar-item ablog__recentposts">
<h3>
  <a href="blog.html">Recent Posts</a>
</h3>
<ul>
  <li>
    <a href="release/ablog-v0.11-released.html">
      25 July - ABlog v0.11 released
    </a>
  </li>
  ... etc etc
</ul>
</div>

We should update our ABlog CSS to utilize these new HTML classes for more predictable behavior.

@choldgraf choldgraf added kind: enhancement New feature or request tag: CSS CSS and SCSS related issues labels Nov 19, 2022
@choldgraf
Copy link
Collaborator Author

This one is actually not quite done - as the new release of ABlog will change their CSS classes and we'll need to update again.

@choldgraf choldgraf reopened this Dec 6, 2022
@12rambau
Copy link
Collaborator

12rambau commented Dec 7, 2022

ah sorry I just merged your PR I thought it was good to go

@choldgraf
Copy link
Collaborator Author

No worries! That was just the bulk of the fix but not everything 🙂

@choldgraf
Copy link
Collaborator Author

choldgraf commented Jan 14, 2023

Note that ablog has made this pre-release so we're now getting warnings in our docs - we should update and attach this to the next release. I can try to do it this weekend since my blog uses this :-)

@choldgraf choldgraf added this to the 0.13 milestone Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request tag: CSS CSS and SCSS related issues
Projects
None yet
2 participants