Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar font changes and toggle icon shows up on too-wide screens #1082

Closed
choldgraf opened this issue Dec 14, 2022 · 4 comments · Fixed by #1123
Closed

Sidebar font changes and toggle icon shows up on too-wide screens #1082

choldgraf opened this issue Dec 14, 2022 · 4 comments · Fixed by #1123
Assignees
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working
Milestone

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented Dec 14, 2022

On main we have some regressions in UI behavior when shrinking the screen. There are four things I noticed:

  • The On this page text becomes bigger too soon, while it is still visible
  • The icon to show the right drawer shows up before the sidebar is hidden
  • Clicking on the icon makes the screen go dark but no drawer is shown
  • The same behavior is then present for the primary sidebar on the left

I suspect this is related to the changes with Boostrap 4 -> 5 because that changed the breakpoint behavior.

Here's a demo of what this looks like:

chrome_DBAS1UQvwH

@choldgraf choldgraf added the kind: bug Something isn't working label Dec 14, 2022
@choldgraf choldgraf changed the title Right sidebar font changes and toggle icon shows up too soon Sidebar font changes and toggle icon shows up too soon Dec 14, 2022
@choldgraf choldgraf changed the title Sidebar font changes and toggle icon shows up too soon Sidebar font changes and toggle icon shows up on too-wide screens Dec 14, 2022
@choldgraf choldgraf added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Dec 14, 2022
@choldgraf
Copy link
Collaborator Author

cc @12rambau who I believe did the update to Bootstrap 5 in:

@12rambau
Copy link
Collaborator

I'll have a look whenever I can but that certainly is related to the change in breakpoint behavior. I though I was clever enough to avoid that bu apparently I wasn't ;-)

@12rambau 12rambau added this to the 0.13 milestone Jan 10, 2023
@choldgraf
Copy link
Collaborator Author

choldgraf commented Jan 18, 2023

@12rambau what are your thoughts on this one? I think this is the last "significant" issue before 0.13.

I think it's a decent UX issue, but don't know that it is critical enough to block a 0.13 release, and in the meantime we're going to have more confusion about issues like the Sphinx < 6.0 bug. Do you have a moment to figure out the bug for this one, or should we move it to a future patch release?

@12rambau
Copy link
Collaborator

That's a decent one but I didn't took the time to work on it. If nothing moves until Friday go for the 0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants