Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are failing with a utf encoding error #1125

Closed
choldgraf opened this issue Jan 22, 2023 · 4 comments · Fixed by #1151
Closed

Windows builds are failing with a utf encoding error #1125

choldgraf opened this issue Jan 22, 2023 · 4 comments · Fixed by #1151
Labels
kind: bug Something isn't working

Comments

@choldgraf
Copy link
Collaborator

Our Windows builds are failing with some kind of encoding error. This seems to be related to the sphinx theme builder so we opened an issue to discuss and track there for now:

@choldgraf choldgraf added the kind: bug Something isn't working label Jan 22, 2023
@choldgraf
Copy link
Collaborator Author

My feeling is that this should not block a release because I don't believe we introduced it and it likely affects other versions too - but if others disagree please say so!

@drammock
Copy link
Collaborator

We hit something like this recently in mne-python and @larsoner fixed it by setting env var PYTHONUTF8=1 on windows (I think). I haven't combed the CI log yet though so I'm not positive this is the same error. I'll check next week if nobody beats me to it

@12rambau 12rambau changed the title Windows builds are saying with a utf encoding error Windows builds are failing with a utf encoding error Jan 23, 2023
@12rambau
Copy link
Collaborator

12rambau commented Feb 3, 2023

@drammock I remembered this being solved in one of your PR, am I wrong ?

@drammock
Copy link
Collaborator

drammock commented Feb 3, 2023

I fixed it for the CIs only. It is caused by the emoji in our README --- the README gets parsed as metadata during editable pip installs. The fix is to export the environment variable PYTHONUTF8=1 before doing the pip install on Windows, but I haven't looked yet into whether this is possible to do automatically for the user. The other, simpler fix is to remove the emoji from our README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants