Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme skip link button is not working on some versions of Safari #1205

Closed
choldgraf opened this issue Feb 20, 2023 · 1 comment · Fixed by #1206
Closed

Theme skip link button is not working on some versions of Safari #1205

choldgraf opened this issue Feb 20, 2023 · 1 comment · Fixed by #1206

Comments

@choldgraf
Copy link
Collaborator

I had a user report a bug in the Sphinx Book Theme and realized that the same thing is happening in this theme as well.

It seems like our "skip to main content" link is not working properly in Safari. I tested this out with browserstack.com. Here's what it looks like in Sarafi:

image

And for comparison, here's what it looks like in Chrome (also on browserstack)

image
@choldgraf choldgraf mentioned this issue Feb 20, 2023
Closed
@choldgraf
Copy link
Collaborator Author

I think the issue might be because we are using translate: not transform: translate, and the former is only supported in more recent versions of Safari. Will try a quick PR

@choldgraf choldgraf mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CSS transform for skip link choldgraf/pydata-sphinx-theme
1 participant
@choldgraf