Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize vertical separation in headers #39

Closed
TomAugspurger opened this issue Oct 29, 2019 · 5 comments
Closed

Emphasize vertical separation in headers #39

TomAugspurger opened this issue Oct 29, 2019 · 5 comments

Comments

@TomAugspurger
Copy link
Contributor

Not sure about how to solve this, but it feels like our headers run into each other a bit...

Screen Shot 2019-10-29 at 6 39 57 AM

With the old site, we had some of the headers in boxes. I don't think we want that, but I do thing the two headers, one immediately following the other, looks a bit strange.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 29, 2019

The solution may be to just write text in between the section headers, rather than modifying the styling.

But if we do go with styling, I think making the h2 (Enhancements) a bit larger, and a bit more spacing after the h3 may work.

@jorisvandenbossche
Copy link
Member

Yes, fully agree this should be improved (this belongs to my general "someone with css skills / design insights should do a full revamp of the look and feel" concern).

So we could make the font size more contrasting, or use some line / shade to better highlight the headers (like we did in our old theme, or how guzzle is doing it http://docs.guzzlephp.org/en/stable/overview.html), or a combination ..

@TomAugspurger
Copy link
Contributor Author

"someone with css skills / design insights should do a full revamp of the look and feel" concern)

Agreed :) But in the meantime, I plan to keep filing small issues, and I'll make some time to work on them in a week or two.

@jorisvandenbossche
Copy link
Member

in the meantime, I plan to keep filing small issues

And that is very much appreciated! ;)

@TomAugspurger
Copy link
Contributor Author

Fixed by #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants