Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box no longer visible by default for pages where sidebar is automatically scrolled down #560

Closed
jorisvandenbossche opened this issue Jan 14, 2022 · 2 comments · Fixed by #744

Comments

@jorisvandenbossche
Copy link
Member

PR #502 made the whole sidebar scrollable, and not only the toctree part of it. That fixed some annoying usability bugs when having multiple elements in the sidebar (see screenshots in #500).

But, that also introduced the minor usability issue that if you go to a page for which the sidebar is automatically scrolled down (eg got to https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/subpages/subsubpages/subsubpage19.html), the search box is now never visible out of the box.
(you have to scroll up in the sidebar (not scroll the page itself, that doesn't influence that) to get to the search box, and scrolling in the sidebar is not something you typically do except for going to another page)

I am not directly thinking of a good solution, but recording the slight concern.
(or at least not a generic solution, without special casing the "search-field" template if it is the first element of html_sidebars, or something like that)

@drammock
Copy link
Collaborator

drammock commented Jan 14, 2022

this is the issue that finally convinces me that the search box should default to being in the top navbar instead of the left sidebar (which has been suggested lately in #221 (comment)).

@damianavila
Copy link
Collaborator

the search box should default to being in the top navbar

I could not agree more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants