Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'count' as option for how in dataset resample #1327

Closed
ghost opened this issue Mar 24, 2017 · 2 comments
Closed

Add 'count' as option for how in dataset resample #1327

ghost opened this issue Mar 24, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 24, 2017

All of the usual aggregations are included in resample, but 'count' is missing.
At present, how='count' fails because the function doesn't accept the kwarg skipna that is being passed to it.

@ghost ghost mentioned this issue Mar 24, 2017
4 tasks
@darothen
Copy link

I saw your PR #1328 on this, but just a heads up that there is an open issue #1269 and pull-request #1272 to re-factor the resampling API to match the GroupBy-like API used by pandas. count() works without any issues on my feature branch.

I've been extremely busy but can try to carve out some more time in the near future to settle some remaining issues on that PR, which would resolve this issue too.

@ghost
Copy link
Author

ghost commented Mar 24, 2017

Thanks for the heads-up @darothen. I browsed the issues to make sure I wasn't duplicating anything, but I must have overlooked the pull request you mentioned.
I have used a lambda function in the interim, so it is no issue if this addition waits until your pull-request is merged in.

@ghost ghost closed this as completed Feb 13, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant