Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate indexing with non-aligned DataArray objects #1333

Closed
shoyer opened this issue Mar 28, 2017 · 2 comments
Closed

Deprecate indexing with non-aligned DataArray objects #1333

shoyer opened this issue Mar 28, 2017 · 2 comments
Milestone
0.10

Comments

@shoyer
Copy link
Member

shoyer commented Mar 28, 2017

Currently, we strip labels from DataArray arguments to [] / .loc[] / .sel()/ .isel(). But this will break when we finally add indexing with alignment (#974).

We could start raising deprecation warnings now so users can stop relying on this functionality that will change.
@shoyer shoyer added this to the 0.10 milestone Mar 28, 2017
@jhamman jhamman mentioned this issue Aug 28, 2017
Closed
13 tasks
@jhamman
Copy link
Member

jhamman commented Oct 19, 2017

@shoyer / @fujiisoup - can this be closed now?

@shoyer
Copy link
Member Author

shoyer commented Oct 20, 2017

Yes, we decided not to do this.

@shoyer shoyer closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
2 participants
@shoyer @jhamman