-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate pynio backend #4491
Comments
Yes, in the long term I think the pynio backend will need to be moved outside of xarray, along with backends for other unmaintained projects such as pydap. This is one of goals of the backend refactor effort lead by @alexamici and @aurghs. Until that happens, if new versions of netCDF4 and pynio are incompatible, my preferred work-around would be to reduce test coverage for pynio. It's not being developed actively, so there aren't strong reasons to maintain test coverage with every version of Python. |
In Keep pynio in
Remove pynio from:
Do you agree? |
not sure if we should repurpose Would it be enough to only test using |
This sounds fine to me. |
Yes, fine for me - check #4492 |
#4492 is merged. I changed the title to reflect that pynio should eventually be moved to an external repo but keep the issue open to have the discussion in place. I hope that this should not be too hard after the backend refactor. |
We just bumped the the minimum version of python-netCDF4 to 1.5 - we won't be able to bump it to 1.6 because of this. So we'll need to decide what to do with pynio before and properly deprecate it. Worth noting though, that there is no python-netCDF4 version 1.6 at the moment, so this is not all that urgent. netCDF4 has not released a minor version in a long time (March 2019) (but they have done 12 patch releases). |
If you want I can take care to move |
That would be nice. I would probably call it "xarray-pynio" (?) and move it to the "xarray-contrib" organisation. However, I think this needs a higher-level decision. |
I agree, that would probably be the best place to put it. We might want do the same for |
I think this is OK. The README should say that it is totally unmaintained. cc @khallock for awareness. |
Hello, sorry to bother you here, can you test again with newer pynio builds? I think pynio-feedstock#90 is now solved. |
We can uncomment here: xarray/ci/requirements/environment.yml Line 36 in 305533d
which adds it back to the test suite. As the version does not change, the new build should also be picked up from
(it's nice to see that the build for pynio is fixed, but the package itself does not seem to be actively maintained). |
Reading here https://www.pyngl.ucar.edu/Nio.shtml it says that PyNIO is in "maintenance mode", what that means is not clear to me. There are no commits since 2019 to the the pynio repo https://github.com/NCAR/pynio. |
#6559 is dropping PyNIO because I can't create a |
I've downloaded a copy of min-all-deps.yml from this repo and run
|
Yes it works now but not after I updated dask and scipy versions in #6559 |
My bad, I did not understand correctly what min-all-deps is for. I really have no clue if this can be solved, I only know that to get pynio to work with newer hdf5 required a change in build config for hdf5 (a compatibility macro) and a compiler flag in pynio. |
I suggest we plan to remove the pynio backend in a future release. The project is very likely dead. |
Does it make sense to move it to its own repo, seeing that this package is no longer maintained? |
I changed the title of this issue to reflect the current situation. PyNIO is unlikely to have another release and its compatibility with the Xarray and the rest of the ecosystem is quickly waning. If someone decides to pick up PyNIO maintenance in the future, they can provide backend entrypoint. |
We are currently not testing with the newest version of netCDF4 because it is incompatible with pynio (the newest version is 1.5.4, we are at 1.5.3). This is unlikely to be fixed, see conda-forge/pynio-feedstock#90.
Therefore we need to think how to setup the tests so we use the newest version of netCDF4. Maybe just remove it from
py38.yml
?And long term what to do with the pynio backend? Deprecate? Move to an external repo?
The text was updated successfully, but these errors were encountered: