-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Literal type of engine argument incompatible with custom backends #6632
Comments
I don't think we should be using a |
Or we could just have a global variable like |
If you know how that works statically, I don't see a way to do that. |
Yeah, reverting to Str seems to be the most straightforward way. It's unfortunate though Literals are really nice. |
Ok, let's keep this issue open for a bit in case someone still finds a solution. |
What is your issue?
In the recent typing improvements the
engine
argument foropen_dataset
was changed from Str to a Literal of xarrays internal engines.This will cause problems for all third party backend plugins.
We have several possibilities:
Any typing experts here that could help?
The text was updated successfully, but these errors were encountered: