Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resample no longer works with Pandas DateOffset or Timedelta objects #9408

Closed
oliverhiggs opened this issue Aug 28, 2024 · 2 comments · Fixed by #9413
Closed

Resample no longer works with Pandas DateOffset or Timedelta objects #9408

oliverhiggs opened this issue Aug 28, 2024 · 2 comments · Fixed by #9413
Labels
regression topic-groupby

Comments

@oliverhiggs
Copy link
Contributor

What is your issue?

Since version 2024.07.0, resampling raises an error when used with a Pandas DateOffset or Timedelta object. Resampling using these can be done by first creating a TimeResampler object, but this is an extra step and is inconsistent with the way resampling works in Pandas; resample in Pandas accepts objects of these types as arguments.

Would the maintainers consider supporting DateOffset and Timedelta objects directly in resample?
@oliverhiggs oliverhiggs added the needs triage Issue that has not been reviewed by xarray team member label Aug 28, 2024
@dcherian dcherian added topic-groupby regression and removed needs triage Issue that has not been reviewed by xarray team member labels Aug 28, 2024
@dcherian
Copy link
Contributor

Thanks I agree this should be fixed

Are you able to send in a PR with a fix?

@oliverhiggs oliverhiggs mentioned this issue Aug 29, 2024
Merged
@oliverhiggs
Copy link
Contributor Author

Sure, I've added a fix in #9413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression topic-groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support additional dtypes in resample oliverhiggs/xarray
2 participants
@dcherian @oliverhiggs