Change to allow to work with pyinstaller #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 98.96% 98.85% -0.12%
==========================================
Files 31 31
Lines 2604 2611 +7
==========================================
+ Hits 2577 2581 +4
- Misses 27 30 +3
Continue to review full report at Codecov.
|
|
Thanks for the PR. I will code up some unit test for the 11% drop and give some guidance note regarding pyinstaller before release your PR. |
|
Sorry about the test coverage drop. I wasn't sure just how much infrastructure you wanted to bring in to test this, so I just threw it over the wall. Thanks for catching it on the other side. FYI, this originally came from Stack Overflow. |
chfw
added a commit
that referenced
this pull request
Mar 29, 2017
|
v0.3.3 was released to pypi. |
errikos
pushed a commit
to errikos/amtt
that referenced
this pull request
May 9, 2017
Pyexcel loads the appropriate module for each file type dynamically, therefore we need to explicitly tell PyInstaller to import pyexcel.xls. For more information, see this issue: pyexcel/pyexcel-io#31 Signed-off-by: Ergys Dona <errikosd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyinstaller does not support
pkg_utils.iter_modules(). Instead one needs to usepkgutil.get_importer()to see what is available. See pyinstaller/pyinstaller#1905 for details.