Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roadmap] GraphGym via PyTorch Lightning 🚀 #4503

Closed
2 of 5 tasks
aniketmaurya opened this issue Apr 20, 2022 · 2 comments
Closed
2 of 5 tasks

[Roadmap] GraphGym via PyTorch Lightning 🚀 #4503

aniketmaurya opened this issue Apr 20, 2022 · 2 comments

Comments

@aniketmaurya
Copy link
Contributor

aniketmaurya commented Apr 20, 2022

🚀 The feature, motivation and pitch

PyTorch Lightning Integration

GraphGym training experience can be improved for scalability, mixed precision support, logging and checkpoints with PyTorch Lightning integration.

  • Write LightningModule
  • Refactor load_ckpt and save_ckpt with PL checkpoint save and load method
  • Update train method with PL Trainer and the LightningModule implementation
  • Integrate LightningDataset, LightningNodeData and LightningLinkData modules
  • ...
@rusty1s
Copy link
Member

rusty1s commented Apr 20, 2022

Thanks for this effort. I think the roadmap looks pretty good.

  • LightningModule: Ideally, all we need to do is to let create_model return a LightningModule (first PR). This shouldn't break anything as far as I can tell. We can then start adding train_step, val_step and test_step, and configure_optimizers as part of this newly created LightningModule (second PR).
  • As far as I can tell, load_ckpt and save_ckpt could be completely dropped by using PL in-house implementations. Correct me if I am wrong, but I think this has to be done after the LightningModule and its training pipeline have been properly integrated.
  • We can also think about wrapping datasets inside our LightningDataModule.

cc: @JiaxuanYou

@rusty1s rusty1s pinned this issue Jun 6, 2022
@rusty1s rusty1s changed the title PyTorch Lightning Trainer for GraphGym [Roadmap] PyTorch Lightning Trainer for GraphGym 🚀 Jun 6, 2022
@rusty1s rusty1s changed the title [Roadmap] PyTorch Lightning Trainer for GraphGym 🚀 [Roadmap] GraphGym via PyTorch Lightning and Hydra 🚀 Aug 4, 2022
@rusty1s rusty1s changed the title [Roadmap] GraphGym via PyTorch Lightning and Hydra 🚀 [Roadmap] GraphGym via PyTorch Lightning 🚀 Aug 4, 2022
@rusty1s
Copy link
Member

rusty1s commented Aug 4, 2022

Closing this issue in favor of #5132. Thanks for your contributions @aniketmaurya. Hope you are also on board on future refactors of GraphGym :)

@rusty1s rusty1s closed this as completed Aug 4, 2022
@rusty1s rusty1s unpinned this issue Aug 4, 2022
@rusty1s rusty1s added roadmap and removed feature labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants