Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LinkNeighborLoader with sorted timestamps #5602

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Fix LinkNeighborLoader with sorted timestamps #5602

merged 4 commits into from
Oct 4, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 4, 2022

pyg-lib.neighbor_sample introduced the seed_time argument, which allows us to override the timestamp for the given set of seed nodes. This PR introduces the change to PyG, allowing link neighbor loader tests to pass again.

cc @wsad1

@rusty1s rusty1s self-assigned this Oct 4, 2022
@github-actions github-actions bot removed the loader label Oct 4, 2022
@rusty1s rusty1s requested a review from wsad1 October 4, 2022 01:20
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #5602 (fb718fd) into master (adf9c50) will increase coverage by 0.04%.
The diff coverage is 82.35%.

❗ Current head fb718fd differs from pull request most recent head 790467f. Consider uploading reports for the commit 790467f to get more accurate results

@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
+ Coverage   83.72%   83.77%   +0.04%     
==========================================
  Files         346      346              
  Lines       19080    19070      -10     
==========================================
+ Hits        15974    15975       +1     
+ Misses       3106     3095      -11
Impacted Files Coverage Δ
torch_geometric/sampler/neighbor_sampler.py 93.78% <75.00%> (+1.91%) ⬆️
torch_geometric/nn/aggr/multi.py 100.00% <100.00%> (ø)
torch_geometric/sampler/utils.py 87.69% <100.00%> (+7.17%) ⬆️
torch_geometric/loader/link_loader.py 94.02% <0.00%> (+1.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

wsad1
wsad1 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this cleanly. looks good, left some comments.

torch_geometric/sampler/neighbor_sampler.py Outdated Show resolved Hide resolved
torch_geometric/sampler/neighbor_sampler.py Show resolved Hide resolved
torch_geometric/sampler/neighbor_sampler.py Outdated Show resolved Hide resolved
test/loader/test_link_neighbor_loader.py Outdated Show resolved Hide resolved
test/loader/test_link_neighbor_loader.py Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 4, 2022 13:23
@rusty1s rusty1s merged commit 4a9a494 into master Oct 4, 2022
@rusty1s rusty1s deleted the fix_link branch October 4, 2022 13:25
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@rusty1s @JakubPietrakIntel
Fix LinkNeighborLoader with sorted timestamps (pyg-team#5602)
1e500d2 
* update

* fix

* changelog

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 wsad1 approved these changes

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rusty1s @wsad1