We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One of the steps for validating pyhf against ROOT is comparing nuisance parameters, which unfortunately involves some translation of the NP names.
To that end, it looks like one of these duplicated lines should be for "shape" systematics.
https://github.com/pyhf/pyhf-validation/blob/master/scripts/compare_nuisance.py#L37-L38
In my specific use case, this did the trick (but not sure how robust this is for other workspaces): .replace("gamma_shape_", "shape_")
.replace("gamma_shape_", "shape_")
The text was updated successfully, but these errors were encountered:
@jshahinian do you have the xml or that as an example.. I think it's just some of the systematic names have "shape" in your workspace
Sorry, something went wrong.
Hi @lukasheinrich,
Sure, here's an xml example: /afs/cern.ch/work/j/jshahini/public/forLukas/NormalMeasurement_SRee_eMT2a_hghmet_cuts.xml
Sorry in advance if this is just an artifact of our specific naming scheme.
it seems it is
<ShapeSys Name="shape_fakes_stat_fakes_SRee_eMT2a_hghmet_obs_cuts"
but we should support ShapeSys in that script - i'll try to prep a PR
No branches or pull requests
One of the steps for validating pyhf against ROOT is comparing nuisance parameters, which unfortunately involves some translation of the NP names.
To that end, it looks like one of these duplicated lines should be for "shape" systematics.
https://github.com/pyhf/pyhf-validation/blob/master/scripts/compare_nuisance.py#L37-L38
In my specific use case, this did the trick (but not sure how robust this is for other workspaces):
.replace("gamma_shape_", "shape_")
The text was updated successfully, but these errors were encountered: