Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statsmodels hook with hidden imports #100

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Add statsmodels hook with hidden imports #100

merged 6 commits into from
Mar 16, 2021

Conversation

jrm5100
Copy link
Contributor

@jrm5100 jrm5100 commented Mar 15, 2021 •
edited
Loading

Based on this comment

@jrm5100 jrm5100 requested review from a team and Legorooj and removed request for a team March 15, 2021 19:37
bwoodsend
bwoodsend requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to appease the linter. You should be able to run:

flake8 src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-statsmodels.py

without it complaining.

src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-statsmodels.py Outdated Show resolved Hide resolved
@rokm
Copy link
Member

rokm commented Mar 15, 2021

As the hook pertains statsmodels.tsa.statespace subpackage of otherwise large statsmodels package, it might be nicer to have the hook named hook-statsmodels.tsa.statespace.py.

@jrm5100 jrm5100 requested a review from bwoodsend March 15, 2021 21:14
bwoodsend
bwoodsend approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@bwoodsend bwoodsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass.

@bwoodsend bwoodsend merged commit 63a4ebf into pyinstaller:master Mar 16, 2021
@bwoodsend
Copy link
Member

Nice work @jrm5100

@jrm5100 jrm5100 mentioned this pull request Mar 16, 2021
Open
@rokm rokm mentioned this pull request Jun 13, 2021
Closed
@colin-fsa colin-fsa mentioned this pull request Jun 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Legorooj Legorooj Legorooj approved these changes

@bwoodsend bwoodsend bwoodsend approved these changes

@rokm rokm rokm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrm5100 @rokm @bwoodsend @Legorooj