Add office365 hook #125
Add office365 hook #125
Conversation
colin-fsa
requested review from
a team and
Legorooj
and removed request for
a team
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-office365.py
Outdated
Show resolved
Hide resolved
CHANGELOG.rst
Outdated
| @@ -16,6 +16,8 @@ New hooks | |||
| <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/83>`_) | |||
| * Added a hook for the 'pygraphviz' library (`#86 | |||
| <https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/86>`_) | |||
| * Add a hook for ``Office365-REST-Python-Client`` which uses data files in | |||
| some methods | |||
There was a problem hiding this comment.
This isn't how our changelog works. Editing the changelog directly invariably leads to merge conflicts when multiple PRs add to the same file in the same place. Instead write a news entry.
There was a problem hiding this comment.
Apologies for that, I had gotten confused by the instructions in the developer guide. Do you think we could rework that a bit to clarify expectations? I'd be happy to take a stab at revising it, just not sure how to do so.
There was a problem hiding this comment.
Hmm, I've got a half written branch collecting dust somewhere which would do it if I ever finish it. It's also going to explain how to write tests (which I see you've had to guess at - although you guessed right), how to trigger our custom CI/CD, and the copyright header (which most people forget).
Sure thing! It looks like your test suite works by running code that will throw an exception without the hook so I went with that methodology. I found a way without creating a real request to reproduce the failure, the lines in the test print some stuff to stdout if the hook is present (success) and throw exceptions if the hook is absent (failure). |
There was a problem hiding this comment.
Nice. Next you've got a linter to appease. I suggest that you run it locally otherwise Github's new approve CI run feature will drive us both nuts.
pip install flake8
git diff -U0 origin/master -- | flake8 --diff -
Depending on how your remotes are set up, you might need to replace origin/master with the last commit ID that you didn't write yourself.
src/_pyinstaller_hooks_contrib/hooks/stdhooks/hook-office365.py
Outdated
Show resolved
Hide resolved
A hook is needed to bring in 3 .xml data files used by the SharePoint API
|
Nice work @colin-fsa |
|
Thanks @bwoodsend! Appreciate all of your assistance with learning the ropes. |
A hook is needed to bring in 3 .xml data files used by the SharePoint API Authored-by: cscheriff <62242803+cscheriff@users.noreply.github.com>
No description provided.