Adds hook for sunpy #134
Merged
Adds hook for sunpy #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreypaul15
requested review from
a team and
rokm
and removed request for
a team
bwoodsend
requested changes
Jun 24, 2021
There was a problem hiding this comment.
OK, give it a news entry and maybe stick a comment in the hook to say this is just a legacy hook - sunpy >= x.y.z ships its own hooks.
Then we'll call it a day...
Sure, thanks for the help |
Legorooj
force-pushed
the
master
branch
10 times, most recently
from
8003b05
to
df3371d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the suggestions over at #112
This hook only contains the files and imports which do not any tests.