add hook for workflow

[zhouronghua]

need to hook for workflow

[bwoodsend]

This looks fine, but you need to add a changelog file. See the news readme.

[bwoodsend]

Almost. This is PR 17 so you just need to rename that file.

[bwoodsend]

Ahh I see this is already merged. @Legorooj Would it be easier to revert and ask zhouronghua to correct the name or just sort it ourselves?

[Legorooj]

@bwoodsend I didn't notice that, so good catch, but the number is actually semi-valid: #19. There's probably no point changing it now, cause that issue links back to this PR (albeit in a roundabout manner).

In this case, amending the commit locally and pushing is probably the easiest thing - I enabled force pushing to this repository. When you get write access to the main PyInstaller repository remember you can't force push, so no history rewriting. Check 5 times more than necesarry before merging something on the main repo.

[zhouronghua]

Ahh I see this is already merged. @Legorooj Would it be easier to revert and ask zhouronghua to correct the name or just sort it ourselves?

sorry, not familier with the workflow, i thought the number was the issue i just generate, but in fact it is the pull request no

[Legorooj]

@zhouronghua issues and PRs share the numbers, so if there's no issue for it already, then just use the PR number.

[zhouronghua]

@zhouronghua issues and PRs share the numbers, so if there's no issue for it already, then just use the PR number.
i get it, thank u

[bwoodsend]

There we go. Sorted now. @zhouronghua For future reference - the xxx.new.rst file goes in the news/ folder rather than the root. Other than that - good work!