Add gmplot hook #21
Add gmplot hook #21
Conversation
amifunny
requested review from
a team and
bwoodsend
and removed request for
a team
There was a problem hiding this comment.
Grr why can no-one find it? Read the news readme.
The hook itself is good.
|
Added the Apache License to hook and |
What you've done is fine. It only needs to be a one-liner really. |
|
@Legorooj I think this is ready to go. Just waiting for your approval then we can merge... |
|
License info is changed back to GPL. Kindly change the copyright year as required. |
|
@amifunny also, if you're not already using a local environment with the Git CLI or another more advanced Git Client (GitHub desktop at the minimum), I'd recommend you set one up. I'd also suggest you read Git Pro if you haven't already. It's really good - I learned everything I know about Git from that book and about 10 StackOverflow questions. |
|
@Legorooj thanks for the suggestion. I have Git CLI on my system and learned git using for this resource https://lab.github.com/ and a lot of articles with practical use cases. I think you might be under this impression because I uploaded and edited files using web interface only. I choose it over cloning and editing, as it was a simple file addition task. |
|
@amifunny ah ok. |
Due to the issue faced by users of gmplot with conversion to .exe using PyInstaller, this hook was created to include data files along with gmplot. Fixes #20.