Add pyav hooks #29
Merged
Add pyav hooks #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyav uses a cython module which imports sub-modules. These are not normally detected by pyinstaller. This hook uses collect_submodules to add the missing modules as hidden imports.
liupx1988
requested review from
a team and
bwoodsend
and removed request for
a team
pyav uses a cython module which imports sub-modules. These are not normally detected by pyinstaller. This hook uses collect_submodules to add the missing modules as hidden imports.
|
It seems test failed while tests/scripts is missing. |
|
Yeah, the tests need some surgery. But your stuff seems to be passing. Nice work. I'll let @Legorooj have a final check before merging... |
bwoodsend
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyav uses a cython module which imports sub-modules. These are not
normally detected by pyinstaller. This hook uses collect_submodules
to add the missing modules as hidden imports.