Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: add uvicorn #300

Merged
merged 8 commits into from
Aug 23, 2021
Merged

hooks: add uvicorn #300

merged 8 commits into from
Aug 23, 2021

Conversation

imba-tjd
Copy link
Contributor

@imba-tjd imba-tjd commented Aug 23, 2021

I have seen pyinstaller/pyinstaller#4664
But I think it's OK to include the whole uvicorn, because it's pure Python.

@imba-tjd imba-tjd requested review from a team and rokm and removed request for a team August 23, 2021 11:21
@bwoodsend
Copy link
Member

Ughh I hate libraries that do this. Having both dynamical imports and optional dependencies means that we simultaneously must and must not use collect_submodules(). And our tests will always be either hopelessly inadequate in that they provide almost zero coverage or have to brute force iterate through all the permutations and take hours like our scikit-image tests.

@bwoodsend bwoodsend merged commit 7515f0e into pyinstaller:master Aug 23, 2021
@bwoodsend
Copy link
Member

Thanks @imba-tjd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants